Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Debug, Warn, Error logging. #2490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephenwithav
Copy link

Replace the Infof logging with the appropriate level to reduce clutter.

@stephenwithav stephenwithav requested a review from a team as a code owner October 18, 2024 18:18
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #2488, looks good to me

@ChristopherHX ChristopherHX linked an issue Oct 18, 2024 that may be closed by this pull request
Copy link
Contributor

mergify bot commented Oct 18, 2024

@stephenwithav this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (5a80a04) to head (5a1e0d9).
Report is 121 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2490       +/-   ##
===========================================
+ Coverage   61.56%   75.01%   +13.45%     
===========================================
  Files          53       62        +9     
  Lines        9002    10008     +1006     
===========================================
+ Hits         5542     7508     +1966     
+ Misses       3020     1937     -1083     
- Partials      440      563      +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephenwithav
Copy link
Author

The OS/X check failed.

@ChristopherHX
Copy link
Contributor

Only a GitHub Actions infra degregation, rerunning now.

Artifact upload failed.

Another approval till merge.

@mergify mergify bot removed the needs-work Extra attention is needed label Oct 18, 2024
@stephenwithav
Copy link
Author

This PR works, but act -q is closer to what I wanted.

@mcascone
Copy link

mcascone commented Nov 6, 2024

@ChristopherHX @stephenwithav this appears ready to go, will this be merged soon? Thanks!

@ChristopherHX
Copy link
Contributor

@mcascone I respect the merge requirements of this project, unless there is a regression with major impact or no reviews for n-months. Where n is an natural number > 1, the latter never happend yet.

Merge requirement for this pr are two maintainer approvals for outside contributions.

@mcascone
Copy link

@mcascone I respect the merge requirements of this project, unless there is a regression with major impact or no reviews for n-months. Where n is an natural number > 1, the latter never happend yet.

Merge requirement for this pr are two maintainer approvals for outside contributions.

I totally understand this. So in a week or three, if there are no more reviews, it'll be mergeable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable debug mode
3 participants