-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate Debug, Warn, Error logging. #2490
base: master
Are you sure you want to change the base?
Incorporate Debug, Warn, Error logging. #2490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #2488, looks good to me
@stephenwithav this pull request has failed checks 🛠 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2490 +/- ##
===========================================
+ Coverage 61.56% 75.01% +13.45%
===========================================
Files 53 62 +9
Lines 9002 10008 +1006
===========================================
+ Hits 5542 7508 +1966
+ Misses 3020 1937 -1083
- Partials 440 563 +123 ☔ View full report in Codecov by Sentry. |
The OS/X check failed. |
Only a GitHub Actions infra degregation, rerunning now. Artifact upload failed. Another approval till merge. |
This PR works, but |
@ChristopherHX @stephenwithav this appears ready to go, will this be merged soon? Thanks! |
@mcascone I respect the merge requirements of this project, unless there is a regression with major impact or no reviews for n-months. Where n is an natural number > 1, the latter never happend yet. Merge requirement for this pr are two maintainer approvals for outside contributions. |
I totally understand this. So in a week or three, if there are no more reviews, it'll be mergeable? |
Replace the
Infof
logging with the appropriate level to reduce clutter.